Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove number icon indicating popularity from schedule calendar view #3

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Jul 31, 2024

this PR related to issue fossasia/eventyay-talk#155

Summary by Sourcery

Removed the number icon indicating popularity from the schedule calendar view in both the main application and session components.

Copy link

sourcery-ai bot commented Jul 31, 2024

Reviewer's Guide by Sourcery

This pull request removes the number icon indicating popularity from the schedule calendar view and the favorite count display from the session component. These changes simplify the UI by eliminating elements that display the popularity of sessions.

File-Level Changes

Files Changes
src/App.vue
src/components/Session.vue
Removed UI elements related to the popularity indicator and favorite count from the schedule calendar view and session component.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The removal of the sorting option (bunt-select) in App.vue wasn't mentioned in the PR description or the linked issue. Could you clarify if this was intentional and part of the requirements?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@mariobehling mariobehling merged commit 5cf0382 into fossasia:master Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants