-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated the painter to have the same UI for each screen size. #1096
base: flutter_app
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThe changes update the DrawBadgePaint class to make the badge UI consistent across different screen sizes by introducing screen-width-dependent path offsets and adjusting the rotation angle. Updated class diagram for DrawBadgePaintclassDiagram
class DrawBadgePaint {
List~List~bool~~ grid
Color color
draw(Canvas canvas, Size size)
}
note for DrawBadgePaint "Updated to include screen-width-dependent path offsets and adjusted rotation angle."
DrawBadgePaint : +double pathOffsetX1
DrawBadgePaint : +double pathOffsetX2
DrawBadgePaint : +double pathOffsetX3
DrawBadgePaint : +const double radians = math.pi / 3
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Jhalakupadhyay - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider defining the path offset values (0.15, 0.3, 0.15) as named constants with meaningful names to improve code readability and maintainability.
- Please explain the reasoning behind changing the rotation angle from π/4 to π/3, as this represents a significant visual change not mentioned in the PR description.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
#1095
I have added the screen Utils property for the width of the screen this will handle the cells size as per the screen size and the draw badge screen UI will remain same for each screen sizes.
Summary by Sourcery
Enhancements: