Have serde serialization match strum. #7
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The serialization Serde was producing didn't match what we expected it to. This PR adds renames so that our external serialization is correct as well as tests to keep them updated/in-sync.
I bumped the version to 3 since technically this change is breaking I think - even though in reality I'm not sure it actually would.
Acceptance criteria
Testing plan
Kind
enum matches a known good external serialization with no duplicates.Risks
If something else depends on the serde deserialization for
Kind
then that code could break/data could need to be fixed.Checklist