Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert MSB errors to warnings #1469

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Convert MSB errors to warnings #1469

merged 6 commits into from
Sep 12, 2024

Conversation

jssblck
Copy link
Member

@jssblck jssblck commented Sep 10, 2024

Overview

When a user has configured a project to be linked to a binary via MSB, and then they lose access to the project (either because a different user is running the scan, or the project has been deleted, or some other reason) the scan currently fails:

Failed to resolve dependencies for the following FOSSA projects:
	custom+19518/some-project$some-revision

You may not have access to the projects, or they may not exist (see the warnings below for details).
If desired you can use --experimental-skip-vsi-graph to skip resolving the dependencies of these projects.

The user then has to use --experimental-skip-vsi-graph to resolve this issue.
This PR alters the error to be a warning instead of a fatal error.

The --experimental-skip-vsi-graph flag is still there so that users using it don't encounter problems, but it is now largely irrelevant (it would only suppress this warning).

Acceptance criteria

This error is now a warning.

Testing plan

This is proven in the type system, I don't believe it requires testing.
No tests currently exist for this functionality, so I didn't alter any existing tests.

Risks

No risk.

Metrics

None

References

https://fossa.atlassian.net/browse/ANE-2005

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@jssblck jssblck requested a review from a team as a code owner September 10, 2024 23:49
@jssblck jssblck requested a review from spatten September 10, 2024 23:49
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There's a failing test that needs to be fixed or removed, but the code itself is good to ship!

@jssblck jssblck merged commit 968ed2d into master Sep 12, 2024
19 checks passed
@jssblck jssblck deleted the msb/warn branch September 12, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants