Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghc dist new style cache #1294

Closed
wants to merge 67 commits into from
Closed

Ghc dist new style cache #1294

wants to merge 67 commits into from

Conversation

csasarak
Copy link
Contributor

@csasarak csasarak commented Oct 4, 2023

Overview

This PR adds caching of dist-newstyle in our CI. The reason we didn't have this before is that cabal/ghc didn't use file hashes to determine what to rebuild so when they went to build our project every file looked like a new one even with a restored cache.

  • I separated integration tests into their own cache. Because they run on a different system they were interfering with the other Linux builds.

Acceptance criteria

If this PR is successful, what impact does it have on the user experience?

Example: When users do X, Y should now happen.

Testing plan

How did you validate that this PR works? What literal steps did you take when manually checking that your code works?

Example:

  1. Set up test case X.
  2. Run command Y. Make sure Z happens.

This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).

Risks

Highlight any areas that you're unsure of, want feedback on, or want reviewers to pay particular attention to.

Example: I'm not sure I did X correctly, can reviewers please double-check that for me?

Metrics

Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it

References

Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.

Example:

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

This is meant to alleviate an issue with memory that GHC has when compiling.
Get the same stack issues as before.
@csasarak csasarak changed the base branch from master to ghc-9.4-compat October 4, 2023 19:05
Base automatically changed from ghc-9.4-compat to master October 4, 2023 19:20
@csasarak csasarak closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant