WebClient: Send Accept-Encoding #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guzzle does not send `Accept-Encoding` header by default. That is equivalent to sending `Accept-Encoding: *`: https://www.rfc-editor.org/rfc/rfc9110#field.accept-encoding> Most servers will probably return an uncompressed body in response to that, which can be considered wasteful, and can trigger crawler detection systems: #1481 Others might even opt to use a compression method that is not supported by the system (e.g. when libcurl is not compiled with brotli support). Let’s force Guzzle to let curl send `Accept-Encoding` header reflecting which compression methods it supports: guzzle/guzzle#3215
✅ Deploy Preview for selfoss canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guzzle does not send
Accept-Encodingheader by default. That is equivalent to sendingAccept-Encoding: *. Most servers will probably return an uncompressed body in response to that, which can be considered wasteful, and can trigger crawler detection systems. Others might even opt to use a compression method that is not supported by the system (e.g. when libcurl is not compiled with brotli support).Let’s force Guzzle to let curl send
Accept-Encodingheader reflecting which compression methods it supports: guzzle/guzzle#3215Fixes: #1481