Skip to content

Commit

Permalink
client: Replace lodash.pick with lodash-es
Browse files Browse the repository at this point in the history
The former has not been updated for a while, and contains
a prototype pollutioon vulnerability:
GHSA-p6mc-m468-83gw

We were not affected since we supply the properties ourselves
but this will rid of the `npm audit` complaining.

Also, the per-method lodash packages are discouraged so this
will make the code more future proof:
https://lodash.com/per-method-packages
  • Loading branch information
jtojnar committed Apr 6, 2024
1 parent cfe1536 commit cc629a1
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion client/js/templates/Source.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import PropTypes from 'prop-types';
import nullable from 'prop-types-nullable';
import { unescape } from 'html-escaper';
import classNames from 'classnames';
import pick from 'lodash.pick';
import { pick } from 'lodash-es';
import SourceParam from './SourceParam';
import { Spinner } from './Spinner';
import * as sourceRequests from '../requests/sources';
Expand Down
12 changes: 6 additions & 6 deletions client/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"focus-trap": "^7.0.0",
"form-urlencoded": "^6.0.0",
"html-escaper": "^3.0.0",
"lodash.pick": "^4.4.0",
"lodash-es": "^4.17.21",
"prop-types": "^15.7.2",
"prop-types-nullable": "^1.0.1",
"ramda": "^0.29.0",
Expand Down

0 comments on commit cc629a1

Please sign in to comment.