-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added shortcut key "ctrl + s" for saving projects on the go. #493
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great with the save functionality moved to the utils section for further reuse.
The current approach is not the best. References: |
I did but that has the same issue, whenever you are within a text field it works fine but apart from that ctrl + s is not detected. I tried using an arrow key and that works just fine. |
Did you try the approach on a simple flutter app first? |
I tried implementing in this app itself, but will try on a simple app and give an update accordingly. |
@Rupamthxt I have updated the code .. You can investigate why it is not working and make any improvements that work in the |
@ashitaprasad Alright! Will take care of that |
@ashitaprasad Just found out the issue was due to problems with the focus of widgets, fixed it there. Now ctrl + s works from everywhere. |
@Rupamthxt In my last comment I had clearly specified not to modify the |
@ashitaprasad I think I misunderstood it. Working on it. But adding the |
Update the PR with what is currently working at your end with minimal changes to |
@ashitaprasad This is the most minimal change that could have been done. |
Launch app -> Ctrl+S -> Save works |
This works on my end. I tested the build version as well. |
It is not working on macOS. What is your OS? |
I develop on windows. |
PR Description
Added a KeyboardListner which detects key strokes to look for any "ctrl + s" keystrike in a textFeild which in turn triggers the save button to provide ease of use.
Related Issues
Checklist
main
branch before making this PRflutter test
) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.