-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: SoC: NSIM reorganization #7
base: agishev_foss_main
Are you sure you want to change the base?
Conversation
@evgeniy-paltsev, could you please take a look? |
dts/riscv/snps/rmx5xx.dtsi
Outdated
@@ -0,0 +1,63 @@ | |||
/ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it doesn't represent any real SoC/board probably it worth to move it to board directory (as we have it for nSIM classic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
9597c7d
to
78b5f1c
Compare
tests/ztest/error_hook/src/main.c
Outdated
@@ -60,7 +60,7 @@ __no_optimization static void trigger_fault_illegal_instruction(void) | |||
*/ | |||
__no_optimization static void trigger_fault_access(void) | |||
{ | |||
#if defined(CONFIG_SOC_ARC_IOT) || defined(CONFIG_SOC_NSIM) || defined(CONFIG_SOC_EMSK) | |||
#if defined(CONFIG_SOC_ARC_IOT) || defined(SOC_FAMILY_NSIM_ARC_CLASSIC) || defined(CONFIG_SOC_EMSK) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for note: I'd expect that it's needed for all nSIM targets, not only for ARC_CLASSIC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
# nsim_isa_host_timer=0 | ||
# nsim_isa_host_timer_mhz=50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop this commented timer stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
cpu0_intc: interrupt-controller { | ||
compatible = "riscv,cpu-intc"; | ||
interrupt-controller; | ||
#address-cells = <0>; | ||
#interrupt-cells = <1>; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering what is this interrupt controller. I'd expect that CLINT should be the root interrupt controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not pretty sure about this part. It looks like interface for CLINT. And CLINT has reference to cpu0_intc
boards/snps/nsim/arc_v/rmx5xx.dtsi
Outdated
device_type = "cpu"; | ||
reg = <0>; | ||
clock-frequency = <5000000>; | ||
riscv,isa = "rv64imafdc"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RV64 looks incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
#include "rmx500.dtsi" | ||
|
||
/ { | ||
model = "Synpsys Rmx500"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
NSIM reorganization Signed-off-by: Nikolay Agishev <[email protected]>
No description provided.