Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SoC: NSIM reorganization #7

Draft
wants to merge 1 commit into
base: agishev_foss_main
Choose a base branch
from
Draft

Conversation

kokas-a
Copy link

@kokas-a kokas-a commented May 9, 2024

No description provided.

@kokas-a
Copy link
Author

kokas-a commented May 9, 2024

@evgeniy-paltsev, could you please take a look?

@@ -0,0 +1,63 @@
/ {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it doesn't represent any real SoC/board probably it worth to move it to board directory (as we have it for nSIM classic)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kokas-a kokas-a force-pushed the nsim_soc_reorg branch 2 times, most recently from 9597c7d to 78b5f1c Compare May 13, 2024 19:13
@@ -60,7 +60,7 @@ __no_optimization static void trigger_fault_illegal_instruction(void)
*/
__no_optimization static void trigger_fault_access(void)
{
#if defined(CONFIG_SOC_ARC_IOT) || defined(CONFIG_SOC_NSIM) || defined(CONFIG_SOC_EMSK)
#if defined(CONFIG_SOC_ARC_IOT) || defined(SOC_FAMILY_NSIM_ARC_CLASSIC) || defined(CONFIG_SOC_EMSK)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for note: I'd expect that it's needed for all nSIM targets, not only for ARC_CLASSIC

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment on lines 5 to 6
# nsim_isa_host_timer=0
# nsim_isa_host_timer_mhz=50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop this commented timer stuff

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines +18 to +23
cpu0_intc: interrupt-controller {
compatible = "riscv,cpu-intc";
interrupt-controller;
#address-cells = <0>;
#interrupt-cells = <1>;
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering what is this interrupt controller. I'd expect that CLINT should be the root interrupt controller.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not pretty sure about this part. It looks like interface for CLINT. And CLINT has reference to cpu0_intc

device_type = "cpu";
reg = <0>;
clock-frequency = <5000000>;
riscv,isa = "rv64imafdc";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RV64 looks incorrect.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

#include "rmx500.dtsi"

/ {
model = "Synpsys Rmx500";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

NSIM reorganization

Signed-off-by: Nikolay Agishev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants