Fix packet padding concatenation error (#1819) #1851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when trying to parse packets headers from raw data, if the available data is less than the expected header length the library will try to pad zeroes to it:
impacket/impacket/ImpactPacket.py
Lines 432 to 435 in 3ce41be
The padding worked fine in python 2, the buffer and
'\x00'
are considered bytes.In python 3
'\x00'
is considered a string so we get an error when trying to append it to abytes
buffer:TypeError: can't concat str to bytes
Affected classes so far are: