winregistry.py: handle value name containting backslash character #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielg5
added
the
waiting for response
gabrielg5
approved these changes
Aug 15, 2024
|
Applied suggestions to move forward with the bug resolution |
anadrianmanrique
approved these changes
Aug 19, 2024
|
Hi, Sorry for the late reply, I was on leave. The idea behind accepting a REG_NK was to allow multiple calls on the same key to reuse the result of findKey(), such as when you dump an entire tree. However I don't have a problem with the reviewed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winregistry.Registry.getValue()splits keyValue on backslash to separate key and value. But value names can contain backslash, and calling getValue on such a value will cause a ValueError exception.This commit corrects this bug while keeping compatibility with old code.