This repository has been archived by the owner on Apr 16, 2024. It is now read-only.
Record video #34
Open
Record video #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it closes when the preview closes, along with any associated notifications.
And reorder some sections.
Something went wrong in the merge, causing npm install to fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "Save Video" command for rendering the shader to an mp4 using ffmpeg. This could be great for generating twitter or instagram posts, for example.
I'm a little worried about a can of worms this could open in terms of support issues, but it's probably easier to just call out that this is an experimental feature, put it out there, and see what kinds of problems people run into. I've tested it only on macOS with Homebrew-installed ffmpeg.