ci: checks for bundling #1448
Merged
ci: checks for bundling #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds several checks during the CI of sdr for bundling stability, including
avoid dynamic imports
i. esbuild is able to report an error when dealing with dynamic imports. —supported:dynamic-import=false
ii. log-override to cover dynamic imports
detect fs.read* usage and send warnings if any to make developers aware of the potential risks to esbuild of such a usage.
if there are modules that are not bundle-able, and we are not aware of, the test workflow should fail.
i. maintain an allowlist for dependencies that are not able to be bundled and we have resolved.
add more explanations for the static imports of json files
What issues does this PR fix or reference?
@W-16304503@
Functionality Before
Lack of bundling checks, so new changes might break bundling process with no awareness.
Functionality After
More bundling checks in CI.