Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: definition/version types #1357

Merged
merged 4 commits into from
Jun 28, 2024
Merged

fix: definition/version types #1357

merged 4 commits into from
Jun 28, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Jun 27, 2024

What does this PR do?

Correct the metadata registry entry for DecisionMatrixDefinition. Add DecisionMatrixDefinitionVersion and ExpressionSetDefinitionVersion. It should be parent/child but the type's packaging code wasn't implemented that way.

What issues does this PR fix or reference?

@W-15489723@
forcedotcom/cli#2823

@shetzel shetzel requested a review from a team as a code owner June 27, 2024 21:36
@WillieRuemmele
Copy link
Member

QA Notes


followed my own steps defined in the issue

✅ : retrieved new version, properly listed md in the org

 ➜  ../../oss/plugin-deploy-retrieve/bin/run.js project retrieve start                                      
Retrieving v60.0 metadata from [email protected] using the v61.0 SOAP API
Preparing retrieve request... Succeeded

Retrieved Source
=============================================================================================================================================================
| State   Name                            Type                           Path                                                                                 
| ─────── ─────────────────────────────── ────────────────────────────── ──────────────────────────────────────────────────────────────────────────────────── 
| Created test                            ExpressionSetDefinition        force-app/main/default/expressionSetDefinition/test.expressionSetDefinition-meta.xml 
| Created test_V1                         ExpressionSetDefinitionVersion force-app/main/default/expressionSetVersion/test_V1.expressionSetVersion-meta.xml    
| Created ExpressionSetConsole_UtilityBar FlexiPage                      force-app/main/default/flexipages/ExpressionSetConsole_UtilityBar.flexipage-meta.xml 
➜  dreamhouse-lwc git:(main) ✗  hub:(GLOBAL - DevHub) scratch:([email protected])
 ➜  ../../oss/plugin-deploy-retrieve/bin/run.js project retrieve preview 

No conflicts found.

No files will be deleted.

Will Retrieve [1] files.
 Type                           Fullname Path                                                                              
 ────────────────────────────── ──────── ───────────────────────────────────────────────────────────────────────────────── 
 ExpressionSetDefinitionVersion test_V1  force-app/main/default/expressionSetVersion/test_V1.expressionSetVersion-meta.xml 

No files were ignored. Update your .forceignore file if you want to ignore certain files.
➜  dreamhouse-lwc git:(main) ✗  hub:(GLOBAL - DevHub) scratch:([email protected])
 ➜  ../../oss/plugin-deploy-retrieve/bin/run.js project retrieve start  
Retrieving v60.0 metadata from [email protected] using the v61.0 SOAP API
Preparing retrieve request... Succeeded

Retrieved Source
==================================================================================================================================
| State   Name    Type                           Path                                                                              
| ─────── ─────── ────────────────────────────── ───────────────────────────────────────────────────────────────────────────────── 
| Changed test_V1 ExpressionSetDefinitionVersion force-app/main/default/expressionSetVersion/test_V1.expressionSetVersion-meta.xml 

@mshanemc mshanemc changed the title Sh/fix and add types fix: definition/version types Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants