Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change error message, add UT #1355

Merged
merged 3 commits into from
Jun 28, 2024
Merged

fix: change error message, add UT #1355

merged 3 commits into from
Jun 28, 2024

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

modifies the error message to give a possible hint to look at xml tags
adds UT

What issues does this PR fix or reference?

@W-11537212@

Functionality Before

Error (1): Component conversion failed: Unable to find matching parent xml file for /Users/william.ruemmele/projects/scratches/dreamhouse-lwc/force-app/main/default/objects/Broker__c/validationRules/test.validationRule-meta.xml

Functionality After

Error (ConversionError): Component conversion failed: Invalid XML tags or unable to find matching parent xml file for ValidationRule "test"

@WillieRuemmele WillieRuemmele requested a review from a team as a code owner June 24, 2024 21:57
@mshanemc mshanemc changed the title chore: change error message, add UT fix: change error message, add UT Jun 28, 2024
@mshanemc mshanemc merged commit 1e34691 into main Jun 28, 2024
68 of 71 checks passed
@mshanemc mshanemc deleted the wr/invalidXmlMessage branch June 28, 2024 19:31
@mshanemc
Copy link
Contributor

merging b/c 420 error is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants