@W-17312010@ Preparing dev-5 to replace dev as v5 home branch #1696
Conversation
jfeingold35
force-pushed
the
d/W-17312010-v5-a
branch
from
6b6bd23 to
9c593e7
Compare
| @@ -0,0 +1,63 @@ | |||
| name: automated-release-tasks | |||
There was a problem hiding this comment.
Job copied from dev-4 job of the same name. Needed so that dev-5 (soon to be dev) can take over automatic release branch creation once it becomes Default.
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| workflow_id: 'create-release-branch.yml', | ||
| ref: 'dev' |
There was a problem hiding this comment.
Branch changed to dev instead of dev-5.
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| workflow_id: 'create-release-branch.yml', | ||
| ref: 'dev-4', |
There was a problem hiding this comment.
Branch changed to dev-4 instead of dev.
| @@ -24,7 +24,7 @@ jobs: | |||
| # Increment the version as desired locally, without actually committing anything. | |||
| - name: Locally increment version | |||
| run: | | |||
| npm --no-git-tag-version version prerelease --preid alpha | |||
| npm --no-git-tag-version version prerelease --preid beta | |||
There was a problem hiding this comment.
NOTE: In its current state, branches and releases will be versioned as 5.0.0-beta.N instead of 5.0.0-alpha.N. We could make it so that they release as 5.Y.Z, but my intuition is that we don't want to burn a bunch of early minor version numbers on beta releases any more than we wanted to with alphas.
| @@ -12,3 +12,17 @@ jobs: | |||
| uses: ./.github/workflows/run-tests.yml | |||
| with: | |||
| node-matrix: "[{version: 'lts/*', artifact: 'lts'}, {version: 'latest', artifact: 'latest'}]" | |||
| v4-smoke-test: | |||
There was a problem hiding this comment.
Added this because there's probably value in continuing to run the v4 smoke tests on a daily basis until v4 gets End-Of-Life'd. Prepared to be talked out of that, though.
| node: ['lts/*'] | ||
| runs-on: ${{ matrix.os.vm }} | ||
| timeout-minutes: 60 | ||
| runs-on: macos-latest |
There was a problem hiding this comment.
The old version of this file was just a copy of the one from v4 that I believe won't work properly anyway.
So I'm just directly calling over to the v4 job, which is why I pulled the internals of that job into their own flow on the v4 side.
| @@ -53,7 +53,7 @@ jobs: | |||
| with: | |||
| ctc: false # We've been told we don't have to care about this until someone makes us care. | |||
| sign: true | |||
| tag: latest-alpha-rc # Publish as a release candidate, so we can do our validations against it. | |||
| tag: latest-beta-rc # Publish as a release candidate, so we can do our validations against it. | |||
There was a problem hiding this comment.
Tag changed to beta-rc, beta, etc.
| @@ -46,7 +46,7 @@ function run(): void { | |||
| ); | |||
| return; | |||
| } | |||
| } else if (baseBranch == "dev" || /^release-\d+\.\d+\.\d+$/.test(baseBranch)) { | |||
| } else if (baseBranch == "dev" || /^release-\d+\.\d+\.\d+\.*$/.test(baseBranch)) { | |||
There was a problem hiding this comment.
Turns out a lot of the branch names in here were already dev and main, as opposed to dev-5. Which is unfortunate in that it means the enforcement was probably lax in the past, but on the upside, it sure made this pull request cleaner.
This change allows us to properly recognize release-x.y.z-beta.x and treat it appropriately.
No description provided.