Merge pull request #112 from forcedotcom/fix-readonly-error-message

Fix readonly error message
forcedotcom · Aug 15, 2016 · 280eca7 · 280eca7
2 parents 1a60d0b + 10b6b3a
commit 280eca7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/main/java/com/salesforce/dataloader/controller/Controller.java b/src/main/java/com/salesforce/dataloader/controller/Controller.java
@@ -200,6 +200,13 @@ public void createAndShowGUI() throws ControllerInitializationException {
         File configFile = new File(config.getFilename());
         if (!configFile.canWrite()) {
             String errMsg = Messages.getFormattedString("Controller.errorConfigWritable", config.getFilename());
+
+            String currentWorkingDir = System.getProperty("user.dir");
+            if (currentWorkingDir.startsWith("/Volumes")){
+                //user is trying to launch dataloader from the dmg. this is not supported
+                errMsg = Messages.getString("Controller.errorConfigWritableDmg");
+            }
+
             logger.fatal(errMsg);
             throw new ControllerInitializationException(errMsg);
         }

diff --git a/src/main/resources/messages.properties b/src/main/resources/messages.properties
@@ -120,6 +120,7 @@ Controller.errorFieldTypes=Client not logged in. Cannot set Field Types.
 Controller.errorReferenceTypes=Client not logged in. Cannot set Object Reference Types.
 Controller.errorEntityTypes=Client not logged in. Cannot set Entity Types.
 Controller.errorConfigWritable=Please make sure that the config file: {0} exists and is writable.
+Controller.errorConfigWritableDmg=Data Loader must be installed in the Applications folder. Please copy it to the correct folder and try again.
 Controller.errorConfigSave=Error saving config file: {0}.  Please make sure that it is writable.
 Controller.errorConfigLoad=Error loading config file: {0}.  Please make sure that it exists and is readable
 Controller.errorOperationNotSupported=Requested operation: {0} is not supported.  Please check your configuration.  Supported operations are: insert, update, upsert, delete, extract.