feat: export test formatters #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Export test result formatters instead of coupling them into
AgentTester.details. Doing this prevents ink-ception† issues when plugin-agent and agents are using the same copy ofinkin node_modules†oclif/table unmounts an ink component during
makeTable, which was being called before plugin-agent's unmount of oclif/multi-stage-output. This causes ink to get confused when trying to restore the console which was resulting in aTypeError: console.error is not a functionWhat issues does this PR fix or reference?
[skip-validate-pr]