Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lorentzian function #321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

thissop
Copy link

@thissop thissop commented Apr 1, 2024

Hello!

This library is very helpful, I added a lorentzian function to the periodic fit capability because I use this for modeling peaks in power density spectra of black hole light curves, it might be useful for other areas as well :)

http://emilygraceripka.com/blog/16

@thissop
Copy link
Author

thissop commented Apr 1, 2024

example in use:

image

@TomDonoghue TomDonoghue changed the base branch from main to modes April 7, 2024 18:54
@TomDonoghue TomDonoghue changed the base branch from modes to main April 7, 2024 18:54
@TomDonoghue
Copy link
Member

@thissop - this looks fantastic, thank you for the submission!

Quick Q: would you have any issue with us potentially calling this a 'cauchy' fit function, as I understand it is sometimes also called? In the context of the neural data, we sometimes call the 1/(f**x + k) a 'lorentzian function - so calling this function one as well would likely get a bit confusing!

Also - this is actually great timing as we are currently building in additional fit functions with the ongoing 2.0 developments. In general, we would want to add some test and examples of this fitting - if you have any strong desire to contribute those that's great, but since I'm currently working on related update, if it works for you I can also just merge this directly in, and then add some tests (& maybe a name change, etc) as I work through things from here!

needed to add periodic_mode param to two additional functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants