Skip to content

Commit

Permalink
revert: remove goleak
Browse files Browse the repository at this point in the history
  • Loading branch information
franklinkim committed Apr 16, 2024
1 parent 8882274 commit 2038db3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ require (
go.temporal.io/api v1.8.0
go.temporal.io/sdk v1.15.0
go.temporal.io/sdk/contrib/opentelemetry v0.1.0
go.uber.org/goleak v1.3.0
go.uber.org/zap v1.27.0
golang.org/x/crypto v0.22.0
golang.org/x/sync v0.7.0
Expand Down
3 changes: 0 additions & 3 deletions keeltest/inline_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,9 @@ import (

"github.com/foomo/keel/keeltest"
"github.com/stretchr/testify/assert"
"go.uber.org/goleak"
)

func TestInline(t *testing.T) {
defer goleak.VerifyNone(t)

t.Run("read inline", func(t *testing.T) {
value, ok := keeltest.Inline(t, 1) // INLINE: hello world
assert.True(t, ok)
Expand Down
5 changes: 1 addition & 4 deletions server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import (

"github.com/foomo/keel/service"
"github.com/stretchr/testify/suite"
"go.uber.org/goleak"
"go.uber.org/zap"
"go.uber.org/zap/zaptest"

Expand Down Expand Up @@ -74,9 +73,7 @@ func (s *KeelTestSuite) AfterTest(suiteName, testName string) {
}

// TearDownSuite hook
func (s *KeelTestSuite) TearDownSuite() {
goleak.VerifyNone(s.T())
}
func (s *KeelTestSuite) TearDownSuite() {}

func (s *KeelTestSuite) TestServiceHTTP() {
s.svr.AddServices(
Expand Down

0 comments on commit 2038db3

Please sign in to comment.