Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(font): add Hack-ZeroSlash #78

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

huyenltnguyen
Copy link
Contributor

This PR adds the Hack-ZeroSlash to the repo.

@ayuhito
Copy link
Member

ayuhito commented Jul 31, 2024

Hi @huyenltnguyen, thanks for the PR!

I'm not sure if I should approve this due to the relative obscurity of this font with only 2 stars on GitHub. I'd be more willing to accept a PR from the official Hack font instead since it is the more popular option. Thoughts?

@huyenltnguyen
Copy link
Contributor Author

Hi @ayuhito, thank you for the review.

The only difference between this font and the official Hack font is how number 0 is displayed:

  • Hack displays 0 with an inner dot/blob thing
  • Hack-ZeroSlash displays 0 with an inner slash

We are using the Hack-ZeroSlash font here: https://github.com/freeCodeCamp/freeCodeCamp/tree/main/client/static/fonts/hack-zeroslash. We are exploring options to simplify font consumption in our repos/apps, and FontSource is one of the options, hence the PR.

I understand if you're not comfortable with this addition. We will explore other approaches 🙂

Copy link
Member

@ayuhito ayuhito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a downstream repo of that size is worth supporting, so I'm happy to include it for that use case. Everything looks good to me except for a few nits in metadata.json. 👍

fonts/other/hack-zeroslash/metadata.json Outdated Show resolved Hide resolved
fonts/other/hack-zeroslash/metadata.json Outdated Show resolved Hide resolved
Copy link
Member

@ayuhito ayuhito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉

@ayuhito ayuhito merged commit 96dedf9 into fontsource:main Aug 4, 2024
1 check passed
@ayuhito
Copy link
Member

ayuhito commented Aug 4, 2024

npm error 400 Bad Request - PUT https://registry.npmjs.org/@fontsource%2fhack-zeroslash - That word is not allowed. Please contact support at https://npmjs.com/support if you believe you received this in error.

We may need to wait a little for this package to be published. I'll get NPM support to allowlist this package since it contains the word hack.

@huyenltnguyen huyenltnguyen deleted the feat/hack-zeroslash branch August 5, 2024 17:06
@huyenltnguyen
Copy link
Contributor Author

Oh, that's interesting. Thanks a lot for taking care of that!

@ayuhito
Copy link
Member

ayuhito commented Aug 8, 2024

Hi @huyenltnguyen, it seems NPM cannot help with this one particular blocked word. They said that they'll maybe consider removing this word from the blocklist in the future, but it won't be changing now.

Do you have any alternative suggestions for the name, or do you believe we should revert this PR since it can be a little confusing to change the name of the package and breaks all consistency we have kept so far.

We can technically change the NPM package name through the id and still keep the same public facing name.

@huyenltnguyen
Copy link
Contributor Author

@ayuhito Thank you for going through all the hassles.

I don't think I have the liberty to suggest a name change since I'm not an author of the fonts. Also, "hack" is unfortunately the offending word, but it's the main part of the branding so I don't think it could be replaced :(

I guess the best action now is to revert the addition. And in the future, if the official Hack fonts are added to FontSource, we can ask the Source Foundry team to help with the naming and bring Hack-ZeroSlash back (if this option isn't provided by the official pack still).

I'll prepare the revert PR. I really appreciate your help with this 🙂

@huyenltnguyen huyenltnguyen restored the feat/hack-zeroslash branch August 9, 2024 00:43
huyenltnguyen added a commit to huyenltnguyen/fontsource-font-files that referenced this pull request Aug 9, 2024
ayuhito pushed a commit that referenced this pull request Aug 9, 2024
* Revert "chore: release new versions"

This reverts commit cafd3fc.

* Revert "chore(build): update packages [Manual] [Force]"

This reverts commit a61ddcf.

* Revert "feat(font): add hack-zeroSlash (#78)"

This reverts commit 96dedf9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants