-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(font): add Hack-ZeroSlash #78
Conversation
Hi @huyenltnguyen, thanks for the PR! I'm not sure if I should approve this due to the relative obscurity of this font with only 2 stars on GitHub. I'd be more willing to accept a PR from the official Hack font instead since it is the more popular option. Thoughts? |
Hi @ayuhito, thank you for the review. The only difference between this font and the official Hack font is how number 0 is displayed:
We are using the Hack-ZeroSlash font here: https://github.com/freeCodeCamp/freeCodeCamp/tree/main/client/static/fonts/hack-zeroslash. We are exploring options to simplify font consumption in our repos/apps, and FontSource is one of the options, hence the PR. I understand if you're not comfortable with this addition. We will explore other approaches 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a downstream repo of that size is worth supporting, so I'm happy to include it for that use case. Everything looks good to me except for a few nits in metadata.json
. 👍
Co-authored-by: Ayu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🎉
We may need to wait a little for this package to be published. I'll get NPM support to allowlist this package since it contains the word |
Oh, that's interesting. Thanks a lot for taking care of that! |
Hi @huyenltnguyen, it seems NPM cannot help with this one particular blocked word. They said that they'll maybe consider removing this word from the blocklist in the future, but it won't be changing now. Do you have any alternative suggestions for the name, or do you believe we should revert this PR since it can be a little confusing to change the name of the package and breaks all consistency we have kept so far. We can technically change the NPM package name through the |
@ayuhito Thank you for going through all the hassles. I don't think I have the liberty to suggest a name change since I'm not an author of the fonts. Also, "hack" is unfortunately the offending word, but it's the main part of the branding so I don't think it could be replaced :( I guess the best action now is to revert the addition. And in the future, if the official Hack fonts are added to FontSource, we can ask the Source Foundry team to help with the naming and bring Hack-ZeroSlash back (if this option isn't provided by the official pack still). I'll prepare the revert PR. I really appreciate your help with this 🙂 |
This reverts commit 96dedf9.
This PR adds the Hack-ZeroSlash to the repo.