Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Geist Mono Font #56

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add Geist Mono Font #56

merged 3 commits into from
Jan 11, 2024

Conversation

codejagaban
Copy link
Contributor

This PR adds Geist Mono to the list of font files

ayuhito
ayuhito requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@ayuhito ayuhito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! Just some changes needed for the license attributions. Can we also move the folder from the root of the monorepo to fonts/other?

geist-mono/metadata.json Outdated Show resolved Hide resolved
@codejagaban codejagaban requested a review from ayuhito December 19, 2023 15:23
@codejagaban
Copy link
Contributor Author

Looks good, thanks for the PR! Just some changes needed for the license attributions. Can we also move the folder from the root of the monorepo to fonts/other?

Hi @ayuhito Changes updated

@ayuhito
Copy link
Member

ayuhito commented Dec 26, 2023

Sorry for the late review. The tests are not passing since the folder is missing a LICENSE file. Can you copy over the license file from the original repository? That should clear the tests.

@codejagaban
Copy link
Contributor Author

Hi @ayuhito I have updated the LICENSE

ayuhito
ayuhito approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@ayuhito ayuhito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I ended up travelling. Thanks for the PR!

@ayuhito ayuhito merged commit b06d2f9 into fontsource:main Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayuhito ayuhito ayuhito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codejagaban @ayuhito