Skip to content

Commit

Permalink
Add yamllint, Fix lint for makefile.yml
Browse files Browse the repository at this point in the history
  • Loading branch information
fontivan committed Apr 21, 2024
1 parent 791db80 commit 5c92d64
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 19 deletions.
37 changes: 19 additions & 18 deletions .github/workflows/makefile.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
name: Makefile CI

on:
push:
branches: [ "main" ]
pull_request:
branches: [ "main" ]

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Run make all
run: make all
---
name: Makefile CI

Check failure on line 2 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

2:5 [indentation] wrong indentation: expected 0 but found 4

Check failure on line 3 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

3:1 [trailing-spaces] trailing spaces
"on":
push:
branches: ["main"]
pull_request:
branches: ["main"]

Check failure on line 9 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

9:1 [trailing-spaces] trailing spaces
jobs:
build:

Check failure on line 12 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

12:1 [trailing-spaces] trailing spaces
runs-on: ubuntu-latest

Check failure on line 14 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

14:1 [trailing-spaces] trailing spaces
steps:
- uses: actions/checkout@v3
- name: Run make all
run: make all

Check failure on line 19 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

19:5 [new-line-at-end-of-file] no new line character at the end of file

Check failure on line 19 in .github/workflows/makefile.yml

View workflow job for this annotation

GitHub Actions / build

19:1 [trailing-spaces] trailing spaces
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ PY = python3
VENV = venv
BIN=$(ROOT_DIR)/$(VENV)/bin

all: bashate shellcheck test
all: bashate shellcheck test yamllint

$(VENV): requirements.txt
$(PY) -m venv $(VENV)
Expand All @@ -29,6 +29,10 @@ shellcheck: $(VENV)
test:
$(ROOT_DIR)/test/test.sh

.PHONY: yamllint
yamllint: $(VENV)
$(BIN)/yamllint .

clean:
rm -rf $(VENV)
find . -type f -name *.pyc -delete
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
bashate
shellcheck-py
yamllint

0 comments on commit 5c92d64

Please sign in to comment.