Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formvalidation): no error for missing field on autocheck #2901

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Sep 12, 2023

Description

A followup on #2633
As we centralised the field getter, the error message of a non existing field will occur all the time, even in situations where we definately want to remove field related validation rules if a field is non existing anymore and are aware of that.

Testcase

Broken

  • Remove the second field via red button
  • Console shows 2 errors about the field not being existent
  • submit form via blue button -> error occurs again
    https://jsfiddle.net/fgw1bqr0/3/

Fixed

All fine, no errors
https://jsfiddle.net/lubber/3725m4o1/1/

Closes

#2577 (comment)

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug state/awaiting-reviews Pull requests which are waiting for reviews javascript Pull requests that update Javascript code labels Sep 12, 2023
@lubber-de lubber-de added this to the 2.9.4 milestone Sep 12, 2023
Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added state/awaiting-docs Pull requests which need doc changes/additions and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Sep 13, 2023
@lubber-de lubber-de merged commit 9e5d2f7 into fomantic:develop Sep 13, 2023
8 checks passed
@lubber-de lubber-de deleted the dontLogAutovalidationError branch September 13, 2023 05:25
@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#499

@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Apr 30, 2024
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants