-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): support selection floating or pointing #2883
Merged
lubber-de
merged 2 commits into
fomantic:develop
from
lubber-de:floatingSelectionDropdown
Aug 23, 2023
Merged
fix(dropdown): support selection floating or pointing #2883
lubber-de
merged 2 commits into
fomantic:develop
from
lubber-de:floatingSelectionDropdown
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
Any issue which is a bug or PR which fixes a bug
lang/css
Anything involving CSS
state/awaiting-reviews
Pull requests which are waiting for reviews
labels
Aug 22, 2023
lubber-de
added
the
state/awaiting-docs
Pull requests which need doc changes/additions
label
Aug 22, 2023
ko2in
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that the arrow background reflects the dropdown item hover background color. I noticed this since very long time ago and has faded away from my mind to make this change, but you made it 👍
lubber-de
removed
the
state/awaiting-reviews
Pull requests which are waiting for reviews
label
Aug 23, 2023
Docs regarding the new unlimited feature added by fomantic/Fomantic-UI-Docs#484 |
lubber-de
added
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
and removed
state/awaiting-docs
Pull requests which need doc changes/additions
labels
Dec 18, 2023
lubber-de
added a commit
to fomantic/Fomantic-UI-Docs
that referenced
this pull request
Dec 19, 2023
Added unlimited example for dropdown as of fomantic/Fomantic-UI#2883
lubber-de
added a commit
that referenced
this pull request
Apr 23, 2024
#2883 broke specificity when a (very) long/short variant was used for a search selection dropdown (a pure selection dropdown was not affected
lubber-de
added a commit
to lubber-de/Fomantic-UI
that referenced
this pull request
May 16, 2024
fomantic#2883 broke specificity when a (very) long/short variant was used for a search selection dropdown (a pure selection dropdown was not affected
lubber-de
added a commit
to lubber-de/Fomantic-UI
that referenced
this pull request
Jun 11, 2024
fomantic#2883 broke specificity when a (very) long/short variant was used for a search selection dropdown (a pure selection dropdown was not affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lang/css
Anything involving CSS
state/has-docs
A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo
type/bug
Any issue which is a bug or PR which fixes a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
pointing
orfloating
was usedselection
borders were missingI also added a new
unlimited
variant which does not make the selection menu scrollable but shows all items at once instead. This is especially needed in combination withpointing
. Otherwise the arrow wont be displayed as the arrow is part of the (overflowing) dom node.Testcase
https://jsfiddle.net/lubber/jq3vmLde/7/