Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): support selection floating or pointing #2883

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

lubber-de
Copy link
Member

Description

When pointing or floating was used

  • background color overlayed the border corners of first and last item if menu was not scrolled/overflowed
  • in combination with selection borders were missing
  • inverted upward pointing had wrong arrow direction

I also added a new unlimited variant which does not make the selection menu scrollable but shows all items at once instead. This is especially needed in combination with pointing. Otherwise the arrow wont be displayed as the arrow is part of the (overflowing) dom node.

Testcase

https://jsfiddle.net/lubber/jq3vmLde/7/

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews labels Aug 22, 2023
@lubber-de lubber-de added this to the 2.9.3 milestone Aug 22, 2023
@lubber-de lubber-de added the state/awaiting-docs Pull requests which need doc changes/additions label Aug 22, 2023
Copy link
Member

@ko2in ko2in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that the arrow background reflects the dropdown item hover background color. I noticed this since very long time ago and has faded away from my mind to make this change, but you made it 👍

@lubber-de lubber-de merged commit a8dd05e into fomantic:develop Aug 23, 2023
15 checks passed
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Aug 23, 2023
@lubber-de lubber-de deleted the floatingSelectionDropdown branch August 31, 2023 12:07
@lubber-de
Copy link
Member Author

Docs regarding the new unlimited feature added by fomantic/Fomantic-UI-Docs#484

@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Dec 18, 2023
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request Dec 19, 2023
lubber-de added a commit that referenced this pull request Apr 23, 2024
#2883 broke specificity when a (very) long/short variant was used for a search selection dropdown (a pure selection dropdown was not affected
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this pull request May 16, 2024
fomantic#2883 broke specificity when a (very) long/short variant was used for a search selection dropdown (a pure selection dropdown was not affected
lubber-de added a commit to lubber-de/Fomantic-UI that referenced this pull request Jun 11, 2024
fomantic#2883 broke specificity when a (very) long/short variant was used for a search selection dropdown (a pure selection dropdown was not affected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants