Skip to content

Commit

Permalink
fix(slider): correct computing of gapRatio
Browse files Browse the repository at this point in the history
While the distance between two labels is too short for text at every label,
we find out if we use only ticks with no text (gapRatio > 1)
and apply text at any other tick (gapRatio = 2), any third tick (gapRatio = 3) and so on
  • Loading branch information
Inselhopper committed Sep 24, 2024
1 parent 98a7652 commit 68785fb
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/definitions/modules/slider.js
Original file line number Diff line number Diff line change
Expand Up @@ -765,14 +765,12 @@
gapCounter = 1
;

// While the distance between two labels is too short,
// we divide the number of labels at each iteration
// and apply only if the modulo of the operation is an odd number.
// While the distance between two labels is too short for text at every label,
// we find out if we use only ticks with no text (gapRatio > 1)
// and apply text at any other tick (gapRatio = 2), any third tick (gapRatio = 3) and so on
if (trackLength > 0) {
while ((trackLength / numLabels) * gapCounter < settings.labelDistance) {
if (!(numLabels % gapCounter)) {
gapRatio = gapCounter;
}
gapRatio = gapCounter;
gapCounter += 1;
}
}
Expand Down

0 comments on commit 68785fb

Please sign in to comment.