UIREQ-876: UI tests replacement with RTL/Jest for CancelRequestDialog.js #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigTest Unit Test Statistics134 tests ±0 134 ✔️ ±0 14s ⏱️ -1s Results for commit 9cb9c25. ± Comparison against base commit 54c04a5. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
BogdanDenis
approved these changes
Jun 30, 2023
Terala-Priyanka
requested changes
Jun 30, 2023
src/CancelRequestDialog.test.js
Outdated
| request: { | ||
| id: 'ad038163-7368-44e8-9057-c21bd2b9cd4c', | ||
| instance: { | ||
| title: 'title', |
There was a problem hiding this comment.
You can another test that verifies if the modal displays the instance title as expected from props.request.instance.title
| cancelRequestDialogClose: 'cancelRequestDialogClose', | ||
| }; | ||
|
|
||
| describe('CancelRequestDialog', () => { |
There was a problem hiding this comment.
add test to assert
- if Select component is rendered.
- if 'Confirm' button is disabled after clicking it and the modal is closed after a while?
- if TextArea component with label 'Additional information for patron' is rendered?
There was a problem hiding this comment.
Fixed 1 and 3
src/CancelRequestDialog.test.js
Outdated
Comment on lines
26
to
36
| const cancellationReasons = { | ||
| records: [{ | ||
| name: 'cancellation reasons', | ||
| requiresAdditionalInformation: false, | ||
| }, { | ||
| name: 'other cancellation reasons', | ||
| requiresAdditionalInformation: true, |
There was a problem hiding this comment.
Could you add tests to assert if additional information placeholder is displayed based on "cancellationReasons"?
artem-blazhko
approved these changes
Jul 3, 2023
Dmitriy-Litvinenko
changed the title
Dmitriy-Litvinenko
force-pushed
the
UIREQ-876
branch
from
c346183
to
7acd77d
Compare
Terala-Priyanka
approved these changes
Jul 11, 2023
Dmitriy-Litvinenko
force-pushed
the
UIREQ-876
branch
from
7acd77d
to
9cb9c25
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UI tests replacement with RTL/Jest for CancelRequestDialog.js
Refs
https://issues.folio.org/browse/UIREQ-876