UIREQ-947 Create Jest/RTL test for RequestsRoute.js #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/routes/RequestsRoute.test.js
Outdated
Comment on lines
99
to
122
| const resultsFormatterHandler = () => { | ||
| resultsFormatter.itemBarcode(resultFormatterData); | ||
| resultsFormatter.position(resultFormatterData); | ||
| resultsFormatter.proxy(resultFormatterData); | ||
| resultsFormatter.requestDate(resultFormatterData); | ||
| resultsFormatter.requester(resultFormatterData); | ||
| resultsFormatter.requesterBarcode(resultFormatterData); | ||
| resultsFormatter.requestStatus(resultFormatterData); | ||
| resultsFormatter.type(resultFormatterData); | ||
| resultsFormatter.title(resultFormatterData); | ||
| resultsFormatter.year(resultFormatterData); | ||
| resultsFormatter.callNumber(resultFormatterData); | ||
| resultsFormatter.servicePoint(resultFormatterData); | ||
| }; | ||
| const onClickActions = () => { | ||
| onDuplicate(records[0]); | ||
| buildRecordsForHoldsShelfReport(); | ||
| getHelperResourcePath(); | ||
| massageNewRecord({}); | ||
| resultsFormatterHandler(); | ||
| renderFilters(RequestFilterData.onChange); | ||
| resultIsSelected({ item: { id: 'id' } }); | ||
| viewRecordOnCollapse(); | ||
| }; |
There was a problem hiding this comment.
Could you clarify why you need it?
Using this approach you do not test existing functionality instead of that you trigger a lot of methods that help to increase code coverage.
There was a problem hiding this comment.
resultIsSelected({ item: { id: 'id' } });
viewRecordOnCollapse();
massageNewRecord({});
above 3 methods are used to update the state of object in the code.
jest.mock('react', () => ({
...jest.requireActual('react'),
createRef: jest.fn(),
}));
used above mock to clear console errors
Dmitriy-Litvinenko
approved these changes
Jul 13, 2023
artem-blazhko
approved these changes
Jul 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Jest/RTL test for RequestsRoute.js
Refs: UIREQ-947