UIREQ-939 JEST/RTL test cases for PickupServicePointFilter #1049

KetineniM · 2023-05-19T05:06:18Z

UIREQ-939 JEST/RTL test cases for PickupServicePointFilter
URL: https://issues.folio.org/browse/UIREQ-939

github-actions · 2023-05-19T05:11:08Z

Jest Unit Test Statistics

    1 files ±0   41 suites +1 1m 12s ⏱️ -11s
376 tests +3 376 ✔️ +3 0 💤 ±0 0 ❌ ±0
377 runs +3 377 ✔️ +3 0 💤 ±0 0 ❌ ±0

Results for commit da4d99d. ± Comparison against base commit 4293b90.

♻️ This comment has been updated with latest results.

github-actions · 2023-05-19T05:11:31Z

BigTest Unit Test Statistics

132 tests ±0 132 ✔️ ±0 19s ⏱️ -3s
    1 suites ±0     0 💤 ±0
    1 files ±0     0 ❌ ±0

Results for commit da4d99d. ± Comparison against base commit 4293b90.

♻️ This comment has been updated with latest results.

artem-blazhko

Could you add appropriate changes to changelog file?

artem-blazhko · 2023-05-24T08:51:36Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+jest.mock('@folio/stripes/components', () => ({
+ Accordion: jest.fn(({ name, children, onClearFilter }) => (
+ <div>
+ <div><button type="button" onClick={() => onClearFilter()} data-testid={`clear-${name}`}>Clear</button></div>
+ <div data-testid={`accordion-${name}`}>{children}</div>
+ </div>
+ )),
+ FilterAccordionHeader: jest.fn(() => <div>Filter Accordion Header</div>),
+}));
+
+jest.mock('@folio/stripes/smart-components', () => ({
+ MultiSelectionFilter: jest.fn(() => <div>Multi Selection Filter</div>)
+}));


Could you add mocks to appropriate files here if they does not exist yet - test/jest/__mock__ ?

artem-blazhko · 2023-05-24T08:52:26Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+jest.mock('@folio/stripes/components', () => ({
+ Accordion: jest.fn(({ name, children, onClearFilter }) => (
+ <div>
+ <div><button type="button" onClick={() => onClearFilter()} data-testid={`clear-${name}`}>Clear</button></div>


Suggested change

<div><button type="button" onClick={() => onClearFilter()} data-testid={`clear-${name}`}>Clear</button></div>

<div>

<button

type="button"

onClick={onClearFilter}

data-testid={`clear-${name}`}

>Clear</button>

</div>

artem-blazhko · 2023-05-24T08:54:14Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+ expect(pickupServicePointsButton).toBeInTheDocument();
+ userEvent.click(pickupServicePointsButton);
+ expect(onClear).toHaveBeenCalled();


Could you add two separate tests for each expect?

artem-blazhko · 2023-05-24T08:55:22Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+ onChange.mockClear();
+ onClear.mockClear();
+ });
+ it('should render the component with default props', () => {


The name of the test does not fit test scenario.

sonarcloud · 2023-06-02T07:05:07Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

artem-blazhko · 2023-06-06T13:49:04Z

CHANGELOG.md

@@ -24,6 +24,8 @@
 * Added requestDate token. Refs UIREQ-962.
 * Update `request-storage` okapi interface to `6.0` version. Refs UIREQ-963.
 * UI tests replacement with RTL/Jest for src/PatronBlockModal.js. Refs UIREQ-878.
+* Create Jest/RTL test for PickupServicePointFilter.js Refs UIREQ-939.
+


Could you remove empty line?

artem-blazhko · 2023-06-06T13:49:30Z

test/jest/__mock__/stripesComponents.mock.js

+ <div>
+ <button
+ type="button"
+ onClick={() => onClearFilter()}


Suggested change

onClick={() => onClearFilter()}

onClick={onClearFilter}

artem-blazhko · 2023-06-06T13:51:17Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+ { id: '3', name: 'Service Point 3' },
+];
+
+describe('PickupServicePointFilter', () => {


Could you also check that MultiSelectionFilter is rendered and called with correct props?

artem-blazhko · 2023-06-06T13:52:19Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+ );
+ const pickupServicePointsButton = screen.getByTestId('clear-pickupServicePoints');
+ userEvent.click(pickupServicePointsButton);
+ expect(onClear).toHaveBeenCalled();


Would be great to check that it was called with correct argument.

artem-blazhko · 2023-06-06T13:54:08Z

test/jest/__mock__/stripesComponents.mock.js

 </div>
 )),
- AccordionSet: jest.fn(({ children }) => (
+ AccordionSet: jest.fn(({ children, onToggle }) => (


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

artem-blazhko · 2023-06-06T13:54:21Z

test/jest/__mock__/stripesComponents.mock.js

@@ -33,9 +48,23 @@ jest.mock('@folio/stripes/components', () => ({
 {children}
 </div>
 )),
- ConfirmationModal: jest.fn(() => <div>ConfirmationModal</div>),
+ ConfirmationModal: jest.fn(({ heading, confirmLabel, cancelLabel, onConfirm, onCancel }) => (


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

artem-blazhko · 2023-06-06T13:54:27Z

test/jest/__mock__/stripesComponents.mock.js

 Datepicker: jest.fn(() => <div>Datepicker</div>),
- ErrorModal: jest.fn(() => <div>ErrorModal</div>),
+ ErrorModal: jest.fn(({ label, content, buttonLabel, onClose }) => (


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

artem-blazhko · 2023-06-06T13:54:51Z

test/jest/__mock__/stripesComponents.mock.js

@@ -122,7 +151,24 @@ jest.mock('@folio/stripes/components', () => ({
 {children}
 </div>
 )),
- Select: jest.fn(() => <div>Select</div>),
+ Select: ({ name, label, onChange, required, children, value }) => {


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

artem-blazhko · 2023-06-06T13:55:07Z

test/jest/__mock__/stripesSmartComponents.mock.js

 NotesSmartAccordion: jest.fn(() => null),
 SearchAndSort: jest.fn(() => null),
 ViewMetaData: jest.fn(() => null),
 withTags: jest.fn((WrappedComponent) => (props) => <WrappedComponent {...props} />),
+ ProxyManager: () => (<div data-testid="proxy-manager" />),


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

artem-blazhko · 2023-06-06T13:55:44Z

test/jest/__mock__/stripesSmartComponents.mock.js

@@ -4,8 +4,18 @@ jest.mock('@folio/stripes/smart-components', () => ({
 ClipCopy: jest.fn(() => null),
 makeQueryFunction: jest.fn((value) => value),
 CheckboxFilter: jest.fn(() => null),
+ NoteCreatePage: (props) => {


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

Dmitriy-Litvinenko

Could you please fix feedbacks?

KetineniM · 2023-06-23T10:34:04Z

Could you please fix feedbacks?

I have fixed the feedback issues, could you please check and let me know

Dmitriy-Litvinenko · 2023-06-26T09:17:21Z

Could you please fix feedbacks?

KetineniM · 2023-06-26T10:41:48Z

Could you please fix feedbacks?

I have made all the possible changes. Please let me know if there is anything else remaining.

artem-blazhko · 2023-07-03T08:40:31Z

test/jest/__mock__/stripesComponents.mock.js

+ Accordion: jest.fn(({ children, label, name, onClearFilter }) => (
 <div>
 {label}
 {children}
+ <div>
+ <button
+ type="button"
+ onClick={onClearFilter}
+ data-testid={`clear-${name}`}
+ >Clear
+ </button>
+ </div>
+ <div data-testid={`accordion-${name}`} />
 </div>


Suggested change

Accordion: jest.fn(({ children, label, name, onClearFilter }) => (

<div>

{label}

{children}

<div>

<button

type="button"

onClick={onClearFilter}

data-testid={`clear-${name}`}

>Clear

</button>

</div>

<div data-testid={`accordion-${name}`} />

</div>

Accordion: jest.fn(({ children, label, name, onClearFilter }) => (

<div data-testid={`accordion-${name}`} >

{label}

{children}

<div>

<button

type="button"

onClick={onClearFilter}

data-testid={`clear-${name}`}

>Clear

</button>

</div>

</div>

artem-blazhko · 2023-07-03T08:41:00Z

test/jest/__mock__/stripesSmartComponents.mock.js

@@ -4,8 +4,18 @@ jest.mock('@folio/stripes/smart-components', () => ({
 ClipCopy: jest.fn(() => null),
 makeQueryFunction: jest.fn((value) => value),
 CheckboxFilter: jest.fn(() => null),
+ NoteCreatePage: (props) => {


I do not see the usage of this component inside PickupServicePointFilter. Do we really need to mock it?

artem-blazhko · 2023-07-03T08:43:25Z

src/components/RequestsFilters/PickupServicePointFilter/PickupServicePointFilter.test.js

+ expect(MultiSelectionFilter).toBeInTheDocument();
+ });
+ it('MultiSelectionFilter should render with activeValues', () => {
+ const activeValue = screen.getByText('test');


Suggested change

const activeValue = screen.getByText('test');

const activeValue = screen.getByText(activeValues[0]);

…into UIREQ-939

artem-blazhko · 2023-07-11T13:19:12Z

CHANGELOG.md

@@ -27,6 +27,7 @@
 * Added requestDate token. Refs UIREQ-962.
 * Update `request-storage` okapi interface to `6.0` version. Refs UIREQ-963.
 * UI tests replacement with RTL/Jest for src/PatronBlockModal.js. Refs UIREQ-878.
+* Create Jest/RTL test for PickupServicePointFilter.js Refs UIREQ-939.


Could you move it to the bottom of the list?

sonarcloud · 2023-07-12T11:38:48Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

UIREQ-939 JEST/RTL test cases for PickupServicePointFilter

6e53771

KetineniM requested review from zburke, VSnehalatha, ssandupatla, cchitneedi and artem-blazhko May 19, 2023 05:16

cchitneedi approved these changes May 19, 2023

View reviewed changes

artem-blazhko requested a review from Dmitriy-Litvinenko May 24, 2023 08:30

artem-blazhko requested changes May 24, 2023

View reviewed changes

Review changes updated

6d00b0a

KetineniM requested a review from artem-blazhko June 2, 2023 07:08

CHANGELOG file updated

c8a6baf

artem-blazhko requested changes Jun 6, 2023

View reviewed changes

Review changes Updated

ade22b8

KetineniM requested a review from artem-blazhko June 9, 2023 06:42

Dmitriy-Litvinenko reviewed Jun 12, 2023

View reviewed changes

artem-blazhko reviewed Jul 3, 2023

View reviewed changes

VSnehalatha and others added 3 commits July 5, 2023 09:33

Merge branch 'master' into UIREQ-939

8ecd7e6

Review changes updated

8b893a4

Merge branch 'UIREQ-939' of https://github.com/folio-org/ui-requests …

1e3e136

…into UIREQ-939

KetineniM requested a review from Dmitriy-Litvinenko July 7, 2023 12:46

artem-blazhko reviewed Jul 11, 2023

View reviewed changes

Merge branch 'master' into UIREQ-939

da4d99d

artem-blazhko merged commit c57ab7e into master Jul 12, 2023
5 checks passed

artem-blazhko deleted the UIREQ-939 branch July 12, 2023 11:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UIREQ-939 JEST/RTL test cases for PickupServicePointFilter #1049

UIREQ-939 JEST/RTL test cases for PickupServicePointFilter #1049

KetineniM commented May 19, 2023

github-actions bot commented May 19, 2023 •

edited

Loading

github-actions bot commented May 19, 2023 •

edited

Loading

artem-blazhko left a comment

artem-blazhko May 24, 2023

artem-blazhko May 24, 2023

artem-blazhko May 24, 2023

artem-blazhko May 24, 2023

sonarcloud bot commented Jun 2, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jul 3, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jun 6, 2023

artem-blazhko Jul 3, 2023

Dmitriy-Litvinenko left a comment

KetineniM commented Jun 23, 2023

Dmitriy-Litvinenko commented Jun 26, 2023

KetineniM commented Jun 26, 2023

artem-blazhko Jul 3, 2023

artem-blazhko Jul 3, 2023

artem-blazhko Jul 3, 2023

artem-blazhko Jul 11, 2023

sonarcloud bot commented Jul 12, 2023

	const activeValue = screen.getByText('test');
	const activeValue = screen.getByText(activeValues[0]);

UIREQ-939 JEST/RTL test cases for PickupServicePointFilter #1049

UIREQ-939 JEST/RTL test cases for PickupServicePointFilter #1049

Conversation

KetineniM commented May 19, 2023

github-actions bot commented May 19, 2023 • edited Loading

Jest Unit Test Statistics

github-actions bot commented May 19, 2023 • edited Loading

BigTest Unit Test Statistics

artem-blazhko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Jun 2, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dmitriy-Litvinenko left a comment

Choose a reason for hiding this comment

KetineniM commented Jun 23, 2023

Dmitriy-Litvinenko commented Jun 26, 2023

KetineniM commented Jun 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 12, 2023

github-actions bot commented May 19, 2023 •

edited

Loading

github-actions bot commented May 19, 2023 •

edited

Loading