Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-425 Fixed UX Consistency Issue #632

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chris-hellen
Copy link

Purpose

Implemented new translation keys for "Save & close" buttons in order to support UX consistency
UIORGS-425

Approach

Changed all translation keys from local translations ('ui-organizations.button.saveAndClose') to stripes-components translations ('stripes-components.saveAndClose')

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

@chris-hellen chris-hellen marked this pull request as draft July 12, 2024 18:46
@chris-hellen chris-hellen marked this pull request as ready for review July 12, 2024 18:47
@chris-hellen
Copy link
Author

@NikitaSedyx Hi Mikita, my name is Chris. I am a dev for team Bama and got tasked with this issue for UIORGS. I am assuming permissions is the reason I am not able to request a review from you on the PR but if you could take a look at this or let me know who I should message for review I would really appreciate it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant