Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-423: UX Consistency: HTML Page Title display when third pane (detail record) displays #617

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

alisher-epam
Copy link
Contributor

Purpose

https://folio-org.atlassian.net/browse/UIORGS-423
Update the HTML document title with the Organization name when the third pane opens.

Approach

Screen.Recording.2024-03-25.at.12.55.33.mp4

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam self-assigned this Mar 25, 2024
Copy link

github-actions bot commented Mar 25, 2024

Jest Unit Test Statistics

    1 files  ±0    84 suites  ±0   3m 49s ⏱️ -8s
272 tests ±0  272 ✔️ ±0  0 💤 ±0  0 ±0 
276 runs  ±0  276 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit aecb5e5. ± Comparison against base commit 299aef2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 25, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit aecb5e5. ± Comparison against base commit 299aef2.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alisher-epam alisher-epam requested review from a team March 25, 2024 09:04
@alisher-epam alisher-epam merged commit 2079872 into master Mar 25, 2024
6 checks passed
@alisher-epam alisher-epam deleted the UIORGS-423 branch March 25, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants