Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.1.0 #614

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Release v5.1.0 #614

merged 1 commit into from
Mar 20, 2024

Conversation

alisher-epam
Copy link
Contributor

@alisher-epam alisher-epam commented Mar 19, 2024

Purpose

https://folio-org.atlassian.net/browse/UIORGS-426

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam self-assigned this Mar 19, 2024
@alisher-epam alisher-epam requested review from a team March 19, 2024 14:57
Copy link

github-actions bot commented Mar 19, 2024

Jest Unit Test Statistics

    1 files  ±0    84 suites  ±0   3m 50s ⏱️ -3s
272 tests ±0  272 ✔️ ±0  0 💤 ±0  0 ±0 
276 runs  ±0  276 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 88c47cb. ± Comparison against base commit 56e26c3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 19, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 88c47cb. ± Comparison against base commit 56e26c3.

♻️ This comment has been updated with latest results.

@alisher-epam alisher-epam mentioned this pull request Mar 19, 2024
11 tasks
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only job of a release PR is to update the CHANGELOG; please do not include dependency updates.

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alisher-epam alisher-epam merged commit 299aef2 into master Mar 20, 2024
6 checks passed
@alisher-epam alisher-epam deleted the b5.1 branch March 20, 2024 07:43
NikitaSedyx pushed a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants