Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-397: add privileged donor contacts permissions #592

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

alisher-epam
Copy link
Contributor

Purpose

UIORGS-397 - update permissions for privileged-contacts

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam requested review from usavkov-epam and a team December 15, 2023 08:41
Copy link

github-actions bot commented Dec 15, 2023

Jest Unit Test Statistics

    1 files  ±0    83 suites  ±0   3m 48s ⏱️ +4s
263 tests ±0  263 ✔️ ±0  0 💤 ±0  0 ±0 
266 runs  ±0  266 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 13188d9. ± Comparison against base commit 66b8911.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 15, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 13188d9. ± Comparison against base commit 66b8911.

♻️ This comment has been updated with latest results.

@usavkov-epam
Copy link
Contributor

Please add translations for the new permission sets (here).

...
"permission.*": "Foo bar"
...

Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alisher-epam alisher-epam merged commit 85ea82c into master Dec 15, 2023
6 checks passed
@alisher-epam alisher-epam deleted the UIORGS-397 branch December 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants