Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-392 Search organization on bank account number #585

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Nov 22, 2023

Purpose

https://issues.folio.org/browse/UIORGS-392

Certain libraries need to store organization-specific banking and account information in the organization record, independent of the normal account information stored in an organization record. This banking information is sensitive and requires its own permissions in order to view. These permissions may be assigned to external systems via API in some instances.

Approach

Use getSearchableIndexes util.

Screenshot

chrome_tolHBM9Rm8.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

Jest Unit Test Statistics

    1 files  ±0    83 suites  ±0   3m 43s ⏱️ -6s
257 tests +2  257 ✔️ +2  0 💤 ±0  0 ±0 
260 runs  +2  260 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 545172c. ± Comparison against base commit 9928d2e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 22, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 545172c. ± Comparison against base commit 9928d2e.

♻️ This comment has been updated with latest results.

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team November 24, 2023 10:39
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@usavkov-epam usavkov-epam merged commit cf2c36c into master Nov 27, 2023
6 checks passed
@usavkov-epam usavkov-epam deleted the UIORGS-392 branch November 27, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants