UIORGS-383: add donor info for organization summary #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Organizations/OrganizationDetails/OrganizationSummary/OrganizationSummary.js
Outdated
Show resolved
Hide resolved
zburke
reviewed
Oct 13, 2023
There was a problem hiding this comment.
The code changes LGTM but please verify the desired behavior of the confirmation dialog (which will appear both for vendors and donors). I am not confident the current implementation is correct.
I acknowledge @usavkov-epam's point that there is a separate story for reworking the layout, but if you have already done the work here I do not personally see the need to separate it. Up to you.
src/Organizations/OrganizationForm/OrganizationSummaryForm/OrganizationSummaryForm.js
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
usavkov-epam
approved these changes
Oct 16, 2023
alisher-epam
added a commit
that referenced
this pull request
Oct 18, 2023
* UIORGS-383: add donor info for organization summary * tests: fix failing tests * tests: remove failing snapshots * tests: generate snapshot tests * tests: update snapshot tests * improve: bump package.json, fix organizations summary layout, remove checkbox handler
alisher-epam
added a commit
that referenced
this pull request
Nov 1, 2023
* UIORGS-391: add initial routing config and components * UIORGS-404 bump optional plugins to compatible versions (#572) Use plugins compatible with the requested version of stripes (v9). Refs UIORGS-404 * Release v5.0.0 (#573) * UIORGS-383: add donor info for organization summary (#574) * UIORGS-383: add donor info for organization summary * tests: fix failing tests * tests: remove failing snapshots * tests: generate snapshot tests * tests: update snapshot tests * improve: bump package.json, fix organizations summary layout, remove checkbox handler * feat: add CRUD for banking account types * UIORGS-391: integrate with backend. * tests: add test coverages * remove failing test * tests: add test cases * tests: add test coverages * tests: add test coverage * tests: add test coverages * refactor: code based on comments * test: fix failing tests * update package.json interfaces * update: refactor code and component * test: add test coverage * update: permissions for organization settings * update: permissions for organizations settings * refactor: query key and checkbox component * remove unnecessary permissions * update: permissions for banking-account-types * refactor: change the order of imports * refactor: fix column naming issues * optimize: add settings version for optimistic locking issue * tests: fix failing tests --------- Co-authored-by: Zak Burke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
UIORGS-383 - Designate Organization as donor
Approach
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.