Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIORGS-382 Add a message indicating future functionality for EDI naming convention #569

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Sep 19, 2023

Purpose

https://issues.folio.org/browse/UIORGS-382

In the Integration Details of an organization record, a user cannot change the EDI Naming Convention, but the information pop-up indicates this should work. The functionality should work after implementation of the UIORGS-385

Approach

Display clear message for a user that the feature will be available only in the future realeses.

Screenshots

image

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Jest Unit Test Statistics

    1 files  ±0    64 suites  ±0   3m 11s ⏱️ +6s
215 tests ±0  215 ✔️ ±0  0 💤 ±0  0 ±0 
218 runs  ±0  218 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 8845d8a. ± Comparison against base commit d7a7954.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 8845d8a. ± Comparison against base commit d7a7954.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@usavkov-epam usavkov-epam requested review from a team September 20, 2023 07:53
@NikitaSedyx NikitaSedyx requested review from alisher-epam and a team September 20, 2023 07:54
@usavkov-epam usavkov-epam merged commit d5d736d into master Sep 20, 2023
6 checks passed
@usavkov-epam usavkov-epam deleted the UIORGS-382 branch September 20, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants