UIORGS-336: Creating or changing a vendor code using number generator in Organizations App #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hooked up Number generator to Organizations
Added servint as an optionalOkapiInterface dependency, and protected code against being called when interface is not present
…eat/number_generator
Small tweaks, brought number generator code in line with users PR refs UIORGS-336, UIORGS-337
Update generator code to use the new codes defined in this PR: folio-org/mod-service-interaction#72
Added new permission and blocked access to number generator page based on that permission
Jest Unit Test Statistics 1 files ±0 84 suites ±0 3m 1s ⏱️ -48s For more details on these failures, see this check. Results for commit 5e4e4c2. ± Comparison against base commit fc155d5. ♻️ This comment has been updated with latest results. |
…eat/number_generator
…eat/number_generator
Update to use servint 3
…eat/number_generator
Use new service-interaction
…eat/number_generator
…eat/number_generator
Swapped implementation to full Modal implementation as per the other apps
…eat/number_generator
Changed Button from fullWidth to scale with text
…eat/number_generator
…eat/number_generator
…eat/number_generator
…eat/number_generator
…izations into feat/number_generator
Change back to do what is done on master
…eat/number_generator
Mocked useSettings to rectify failing test
NikitaSedyx
reviewed
Mar 14, 2024
| let vendorCodeSetting = 'useTextField'; | ||
|
|
||
| if (stripes.hasInterface('servint')) { | ||
| vendorCodeSetting = settings?.find(sett => sett?.configName === CONFIG_NAME)?.parsedSettings?.vendorGeneratorSetting ?? 'useTextField'; |
There was a problem hiding this comment.
this and related code should be moved to hook
NikitaSedyx
reviewed
Mar 14, 2024
| /> | ||
| </Col> | ||
| {( | ||
| vendorCodeSetting === 'useGenerator' || |
There was a problem hiding this comment.
plz don't use magic words, additionally IMO you can return boolean values from hook (see previous comment)
NikitaSedyx
reviewed
Mar 14, 2024
| generateButtonLabel={<FormattedMessage id="ui-organizations.numberGenerator.generateVendorCode" />} | ||
| generator="organizations_vendorCode" | ||
| modalProps={{ | ||
| label: <FormattedMessage id="ui-organizations.numberGenerator.vendorCodeGenerator" /> |
NikitaSedyx
reviewed
Mar 14, 2024
| <Col xs={12}> | ||
| <NumberGeneratorModalButton | ||
| buttonLabel={<FormattedMessage id="ui-organizations.numberGenerator.generateVendorCode" />} | ||
| callback={(generated) => change('code', generated)} |
There was a problem hiding this comment.
it would be nice to not create functions and objects in return section
NikitaSedyx
reviewed
Mar 14, 2024
| })); | ||
|
|
||
| jest.mock('@folio/service-interaction', () => ({ | ||
| NumberGeneratorModalButton: () => <div>NumberGeneratorModalButton</div> |
NikitaSedyx
reviewed
Mar 14, 2024
NikitaSedyx
reviewed
Mar 14, 2024
| const NumberGeneratorOptions = (props) => { | ||
| const ConnectedConfigManager = stripesConnect(ConfigManager); | ||
|
|
||
| const defaultValues = { |
There was a problem hiding this comment.
move it outside of component as it's just constant
NikitaSedyx
reviewed
Mar 14, 2024
| @@ -8,4 +8,6 @@ export const PRIVILEGED_CONTACTS_API = 'organizations-storage/privileged-contact | |||
| export const SETTINGS_API = 'organizations-storage/settings'; | |||
| export const TYPES_API = 'organizations-storage/organization-types'; | |||
|
|
|||
| export const CONFIG_API = 'configurations/entries'; | |||
There was a problem hiding this comment.
configurations is deprecated and shouldn't be used for new functionality
NikitaSedyx
requested changes
Mar 14, 2024
|
Moved connected component outside of component render, removed default values
Added messageBanner to settings page explaining the number generator options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: number generator
Adds the number generator functionality to Vendor code.
Also setting page to enable/disable this function, protected by a permission: ui-organizations.settings.numberGenerator.manage
Reflects the PR here:
folio-org/ui-users#2231
and cannot be merged until
ui-service-interactionis accepted for a flower releaserefs UXPROD-3891, UIORGS-336, UIORGS-337