optimize: add settings version for optimistic locking issue

folio-org · Nov 1, 2023 · e2f626a · e2f626a
1 parent 3eed623
commit e2f626a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/src/Settings/BankingInformationSettings/BankingInformationSettings.js b/src/Settings/BankingInformationSettings/BankingInformationSettings.js
@@ -13,6 +13,7 @@ const BankingInformationSettings = () => {
  enabled,
  key,
  id: bankingInformationId,
+ version,
  isLoading,
  refetch,
  } = useBankingInformation();
@@ -22,7 +23,7 @@ const BankingInformationSettings = () => {
  const onSubmit = async ({ value }) => {
  try {
  await ky.put(`${SETTINGS_API}/${bankingInformationId}`, {
- json: { value, key },
+ json: { value, key, _version: version },
  });
 
  refetch();

diff --git a/src/Settings/BankingInformationSettings/BankingInformationSettingsForm.js b/src/Settings/BankingInformationSettings/BankingInformationSettingsForm.js
@@ -48,7 +48,7 @@ const BankingInformationSettingsForm = ({
  <Col xs={12}>
  <Field
  component={Checkbox}
- label={<FormattedMessage id="ui-organizations.settings.bankingInformation" />}
+ label={<FormattedMessage id="ui-organizations.settings.bankingInformation.enable" />}
  name="value"
  type="checkbox"
  />

diff --git a/src/Settings/hooks/useBankingInformation.js b/src/Settings/hooks/useBankingInformation.js
@@ -28,6 +28,7 @@ export const useBankingInformation = () => {
  id: bankingInformation.id,
  enabled: bankingInformation.value === 'true',
  key: bankingInformation.key,
+ version: bankingInformation._version,
  isLoading,
  refetch,
  });

diff --git a/translations/ui-organizations/en.json b/translations/ui-organizations/en.json
@@ -444,6 +444,7 @@
  "settings.typeStatus.Active": "Active",
  "settings.typeStatus.Inactive": "Inactive",
  "settings.bankingInformation": "Banking information",
+ "settings.bankingInformation.enable": "Enable banking information",
  "settings.bankingAccountTypes": "Account types",
  "settings.bankingAccountTypes.cannotDeleteTermHeader": "Cannot delete account type",
  "settings.bankingAccountTypes.cannotDeleteTermMessage": "This account type cannot be deleted, as it is in use by one or more records.",