UIFC-371: Clean viewCollections and findCollections #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alb3rtino
requested changes
Oct 25, 2024
There was a problem hiding this comment.
As you're going to restructure things please take a look at the differences between <ViewCollections> and <FindCollections>. If there are no differences please combine them into a single component. Also please have a look if prop spreading is really required in FilterForm.js.
src/components/Filters/Collections/FindCollections/FindCollections.js
Outdated
Show resolved
Hide resolved
|
alb3rtino
approved these changes
Oct 28, 2024
elsenhans
deleted the
UIFC-371-clean-viewcollections-and-findcollections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/UIFC-371