Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIBULKED-575: Fix "Something went wrong" toast notifications when starting bulk edit #635

Merged
merged 4 commits into from
Oct 30, 2024
Merged

UIBULKED-575: Fix "Something went wrong" toast notifications when starting bulk edit #635

merged 4 commits into from
Oct 30, 2024

Conversation

UladzislauKutarkin
Copy link
Contributor

@UladzislauKutarkin UladzislauKutarkin commented Oct 30, 2024 •
edited
Loading

https://folio-org.atlassian.net/browse/UIBULKED-575

Here we fixed logic for ecs calls in consortia.

Video for ecs env

Screen.Recording.2024-10-30.at.12.27.13.mov

and non-ecs env

Screen.Recording.2024-10-30.at.12.31.27.mov

@UladzislauKutarkin UladzislauKutarkin changed the title UIBULKED-575: "Something went wrong" toast notifications when starting bulk edit UIBULKED-575: Fix "Something went wrong" toast notifications when starting bulk edit Oct 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    45 suites  ±0   3m 7s ⏱️ +6s
290 tests ±0  290 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
297 runs  ±0  297 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2eedb2d. ± Comparison against base commit fd4d46d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 2eedb2d. ± Comparison against base commit fd4d46d.

♻️ This comment has been updated with latest results.

@UladzislauKutarkin UladzislauKutarkin requested review from vashjs and a team October 30, 2024 08:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@UladzislauKutarkin UladzislauKutarkin removed the request for review from NikitaSedyx October 30, 2024 08:47
@UladzislauKutarkin UladzislauKutarkin merged commit 81f1ddf into master Oct 30, 2024
8 of 9 checks passed
@UladzislauKutarkin UladzislauKutarkin deleted the UIBULKED-575 branch October 30, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitaSedyx NikitaSedyx NikitaSedyx approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@vashjs vashjs Awaiting requested review from vashjs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UladzislauKutarkin @NikitaSedyx @BogdanDenis