Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISAUTHCOM-20 Prevent mutating of shared record outside the consortium manager #38

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

usavkov-epam
Copy link
Contributor

@usavkov-epam usavkov-epam commented Sep 27, 2024

Purpose

https://folio-org.atlassian.net/browse/UISAUTHCOM-20

This PR cover missed parts of #24

Approach

Prevent mutation of a shared role outside the consortium manager in the central tenant.

Display role "Type" in the details pane.

Screenshot

chrome_2XDorZjNd2.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@usavkov-epam usavkov-epam self-assigned this Sep 27, 2024
Copy link

github-actions bot commented Sep 27, 2024

Jest Unit Test Statistics

    1 files  ±0    50 suites  ±0   1m 56s ⏱️ +3s
149 tests +2  149 ✔️ +2  0 💤 ±0  0 ±0 
156 runs  +2  156 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 1c48c54. ± Comparison against base commit 9036705.

♻️ This comment has been updated with latest results.

This comment has been minimized.

Copy link

github-actions bot commented Sep 27, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 1c48c54. ± Comparison against base commit 9036705.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented Oct 1, 2024

@usavkov-epam usavkov-epam merged commit 489a437 into master Oct 1, 2024
6 checks passed
@usavkov-epam usavkov-epam deleted the UISAUTHCOM-20 branch October 1, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants