feat(specification-storage): add field tag validation rule #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add FieldTagRuleValidator - Refactor MarcRecordRuleValidator Closes: MRSPECS-44
- Add FieldTagRuleValidator test Closes: MRSPECS-44
- Add tests - Refactor code Closes: MRSPECS-44
- Fix sonar issues Closes: MRSPECS-44
- Revert code Closes: MRSPECS-44
- Add missing rule Closes: MRSPECS-44
viacheslavpoliakov
requested review from
psmagin,
viacheslavkol and
mukhiddin-yusuf
- Fix test Closes: MRSPECS-44
- Fix another test Closes: MRSPECS-44
|
viacheslavkol
approved these changes
Aug 13, 2024
psmagin
changed the title
psmagin
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add missing rule for Field Tag validation
Approach
Add missing rule to existing rules list
Changes Checklist
Related Issues
MRSPECS-44