Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODORDERS-344 poline update batch API #347

Merged
merged 7 commits into from
Sep 4, 2023
Merged

MODORDERS-344 poline update batch API #347

merged 7 commits into from
Sep 4, 2023

Conversation

grabsefx
Copy link
Contributor

@grabsefx grabsefx commented Aug 29, 2023

Purpose

https://issues.folio.org/browse/MODORDSTOR-344

Approach

  • implemented new endpoint
    Unfortunately it was impossible to use batch update for referenced titles due to complicated buissnes logic involved

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all the appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?
  • Did you modify code to call some additional endpoints?
    • If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@grabsefx grabsefx self-assigned this Aug 29, 2023
@grabsefx grabsefx marked this pull request as ready for review August 29, 2023 11:17
@grabsefx grabsefx requested a review from a team August 29, 2023 11:17
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

91.4% 91.4% Coverage
0.0% 0.0% Duplication

@grabsefx grabsefx merged commit 61dd17e into master Sep 4, 2023
6 checks passed

private Future<Void> updateTitles(Conn conn, List<PoLine> poLines) {
var futures = poLines.stream()
.filter(poLine -> !poLine.getIsPackage())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pass getIsPackage as lambda and invert it using Predicate.not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants