MODLISTS-123 Update canned lists to new entity types #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjain110
approved these changes
Sep 27, 2024
bvsharp
approved these changes
Sep 27, 2024
mweaver-ebsco
force-pushed
the
MODLISTS-123-canned-composites
branch
from
64460c0
to
d9bb192
Compare
mweaver-ebsco
commented
Sep 27, 2024
Comment on lines
32
to
33
| 'Inactive patrons with open loans', | ||
| 'Returns all inactive users with a loan status of open', |
There was a problem hiding this comment.
I stealthily changed the list name and description, since they were wrong before (it was "Inactive patrons with open loans" for the title and something similar for the description)
mweaver-ebsco
commented
Sep 27, 2024
| 'Returns all items with a status of: missing, aged to lost, claimed returned, declared lost, long missing', | ||
| 'd0213d22-32cf-490f-9196-d81c3c66e53f', | ||
| '{"items.status_name": {"$in": ["Missing", "Aged to lost", "Claimed returned", "Declared lost", "Long missing" ] }}', | ||
| '{id, item_hrid, holdings_id, item_effective_call_number, item_effective_call_number_typeid, item_effective_call_number_type_name, item_holdings_record_id, item_status, item_copy_number, item_barcode, item_created_date, item_updated_date, item_effective_location_id, item_effective_location_name, item_effective_library_id, item_effective_library_name, item_effective_library_code, item_material_type_id, item_material_type, instance_id, instance_title, instance_created_date, instance_updated_date, instance_primary_contributor, item_level_call_number, item_level_call_number_typeid, item_permanent_location_id, item_temporary_location_id, item_level_call_number_type_name, item_permanent_location_name, item_temporary_location_name}', |
There was a problem hiding this comment.
These field lists need to be updated
mweaver-ebsco
force-pushed
the
MODLISTS-123-canned-composites
branch
from
d9bb192
to
ac50a46
Compare
mweaver-ebsco
force-pushed
the
MODLISTS-123-canned-composites
branch
from
4d23dcc
to
adac0a9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.