Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in draw_range_full_width_lines if range is only one line #484

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

caztanj
Copy link
Contributor

@caztanj caztanj commented Dec 23, 2024

This fixes a bug where the background color in a single line buffer region was too wide.

E.g. #string jai struct jai

This fixes a bug where the background color in a single line buffer
region was too wide.

E.g. #string jai struct jai
@focus-editor focus-editor merged commit 9990b06 into focus-editor:main Dec 24, 2024
@focus-editor
Copy link
Owner

I noticed that when using JS <script> tags it still doesn't look as expected:
image

  1. Black square even when there's nothing in between tags
  2. Last character is not within the region when there is something in between tags
  3. Highlights start at a weird place when tags are on different lines. Ideally we should only highlight the space in between the tags without the lines where the tags are (unless there's something there besides the script tags(

@caztanj
Copy link
Contributor Author

caztanj commented Dec 24, 2024

I can have a look at this in a couple of days. :)

@caztanj caztanj deleted the single_line_range_draw_fix branch December 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants