-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Word Completion #198
base: main
Are you sure you want to change the base?
Conversation
I will review this next week when I'm back from my trip and have cleared the backlog of stuff I have - will do before the next release. |
Checked it out a few days ago, was working pretty nice. Hope it gets merged, it's a solid step towards Jails/lsp support :) |
Sorry for taking this long. I haven't forgotten about it - been sick and didn't work on the editor at all. |
This is getting delayed since I need to take a very careful look at it and we barely have the time to finish the remaining things for the release |
This is a simple stuff which search the buffer for words. I cannot live without that but probably you want to refact the whole thing as it is with more optimization. |
OK finally I'm ready to look at this. Thanks for waiting |
I've tried it once again. The reason I needed to take a careful look at it was because when I tried it at first I wasn't very happy with the behaviour and felt the need to redo it. I hope you're OK if I use your code as a reference and implement the behaviour I'd intended to implement originally. |
If you able to use anything from it then just go ahead. :) |
I haven't forgotten about it, just super busy. Completions should be coming in 0.4.0 (but we haven't shipped 0.3.6 yet :( ) |
Hi! Oh thats gonna be cool it has so many good features already. Yeah, well I just try to keep it uptodate. |
Maybe too complicated in some places, because I don't know the source code fully, so maybe you can do it a simpler way. I've been using this for the past 2 months, and it's not as annoying as LSP is (at least for me). Maybe we need to do some cleanup on this, but initially, I just want to create something that is good and simple.
The extra features:
Start/Step forwards: Ctrl-E
Start/Step backwards: Ctrl-Q
Start/Step forwards (subwords): Ctrl-R (then you can use Ctrl-E and Ctrl-Q too for stepping between results)