Add MemoryLocation {Host, Device} member in bunch_particles to keep track of where particles are
#261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/synergia/bunch/bunch.h modified: src/synergia/bunch/bunch_particles.cc modified: src/synergia/bunch/bunch_particles.h modified: src/synergia/bunch/tests/test_bunch.cc modified: src/synergia/bunch/tests/test_bunch_particles.cc modified: src/synergia/simulation/bunch_simulator.cc modified: src/synergia/simulation/bunch_simulator.h
s-sajid-ali
force-pushed
the
fix_core_diagnostics
branch
from
107c0bd
to
c5c4e3d
Compare
added 5 commits
April 22, 2024 14:56
modified: src/synergia/simulation/propagator.cc
s-sajid-ali
force-pushed
the
fix_core_diagnostics
branch
from
8fbd2e2
to
c0c457b
Compare
s-sajid-ali
changed the title
MemoryLocation {Host, Device} member in bunch_particles to keep track of where particles are
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248 with a broader solution that introduces a new enum member
MemoryLocation { Host, Device }in thebunch_particlesclass to keep track of where the particles reside. This can also be used to track down issues later on, if for instance particle data lives on the host but some function was called with the assumption that data lives on the device.An additional change that occurs due to the above is that any function that moves particles between device/host memories can no longer be
const.