Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add js minified file #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add js minified file #24

wants to merge 1 commit into from

Conversation

atefBB
Copy link
Contributor

@atefBB atefBB commented Jun 7, 2017

Hey!
what about adding minified file ng-order-object-by.min.js ?

@fmquaglia
Copy link
Owner

@atefBB I like the idea of having a minified dist file, but I wouldn't put it in a sources directory (src). It would be better to have it in a dist folder.
How did you minify it?

@atefBB
Copy link
Contributor Author

atefBB commented Sep 12, 2017

I'm using this https://github.com/promatik/PHP-JS-CSS-Minifier.

@fmquaglia
Copy link
Owner

@atefBB Gotcha.
I'd like instead of using an external tool have a grunt task as part of the project's Gruntfile, so anyone can build from source without depending on an external tool, and get the very same minified as the project's dist folder. Do you feel you can create the grunt build task yourself?
Otherwise I'll try to make it myself.

@atefBB
Copy link
Contributor Author

atefBB commented Sep 12, 2017

Sorry, but I don't know how to use grunt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants