Fix for issue #31 #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corsair restarts were failing because multi IO units were returning incorrect byte size for particle arrays.
|
I was able to run and restart example_particle corsair case with this patch. |
|
Great! So if you're encountering segfaults in restarted distributed Hybrid runs, chances are that there is a bug in hybrid code. |
|
I will explore the issue further once we have access to Voima again. But so far the patch looks fine to me! |
|
I'm waiting for Vlasiator people to verify that the branch is good. |
|
Oh, apparently I commented only on Flowdock. This failed for us in Vlasiator. |
|
Hi, I saw the comment, haven't fixed it yet. |
|
No problem, I was just making sure. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corsair restarts were failing because multi IO units were returning
incorrect byte size for particle arrays.