on-the-fly data reducers #245
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostahoraites
changed the title
vlsvreader.py: added capability to read_variable() to read on-the-fly data reducers, if the name string includes terms that look like '{variable_name.operator}'
kostahoraites
force-pushed
the
read_variable
branch
from
e6b9865
to
ec0779f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vlsvreader.py: added capability to read_variable() to read on-the-fly data reducers, if the name string includes terms that look like '{variable_name.operator}'
Some comments:
This quick implementation already works remarkably well with other analysator routines---already tested that plot_colormap_3dslice() and and plot_colormap_threeslice() produce the correct plots, with only minor issues in the plot labeling. Also read_interpolated_variable() works with on-the-fly data reducers.
A more robust implementation may require digging into how data reducers work, rather than treating read_variable() as a black box. Lambdas are probably needed to create temporary data reducers.
Also, more secure alternatives to eval() may need to be explored.